phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4601) Perform server-side retries if client version < 4.14
Date Fri, 20 Apr 2018 23:26:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446498#comment-16446498
] 

Hudson commented on PHOENIX-4601:
---------------------------------

FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1844 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/1844/])
PHOENIX-4601 Perform server-side retries if client version < 4.14 (vincentpoon: rev d7afec21c500ccd7f5334e9c0958c40fcc95df14)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/IndexWriterUtils.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/TrackingParallelWriterIndexCommitter.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/ParallelWriterIndexCommitter.java
Revert "PHOENIX-4601 Perform server-side retries if client version < (vincentpoon: rev
5ff900e57c5040ea9ee42d0ca48c0cf68cf86b30)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/TrackingParallelWriterIndexCommitter.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/IndexWriterUtils.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/ParallelWriterIndexCommitter.java
PHOENIX-4601 Perform server-side retries if client version < 4.14 (vincentpoon: rev 78636a3c25a775d4da2cf52c7cdc7c51ef82bb64)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/ParallelWriterIndexCommitter.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/TrackingParallelWriterIndexCommitter.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/IndexWriterUtils.java


> Perform server-side retries if client version < 4.14
> ----------------------------------------------------
>
>                 Key: PHOENIX-4601
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4601
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Vincent Poon
>            Priority: Major
>             Fix For: 4.14.0, 5.0.0
>
>         Attachments: PHOENIX-4601.v1.master.patch, PHOENIX-4601.v2.4.x-HBase-0.98.patch,
PHOENIX-4601.v2.5.x-HBase-2.0.patch, PHOENIX-4601.v2.master.patch
>
>
> The client version is now available on the server side when index maintenance is being
performed. Given that this information is available, we should conditionally retry on the
server depending on the client version (instead of relying on the operator to manually update
the config after clients have been upgraded). 
> With  PHOENIX-4613, the client version has been threaded through to the IndexCommitter.write()
method. All that's left to do is:
> - Always set the config on the server side to have no HBase retries.
> - Add catch of IOException and conditionally call the retrying exception handler code
based on clientVersion < 4.14.0 in TrackingParallelWriterIndexCommitter and ParallelWriterIndexCommitter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message