phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maryannxue <...@git.apache.org>
Subject [GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...
Date Fri, 20 Apr 2018 18:38:07 GMT
Github user maryannxue commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/298#discussion_r183133375
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java ---
    @@ -314,7 +314,8 @@ protected QueryPlan compileJoinQuery(JoinCompiler.Strategy strategy,
StatementCo
                         if (i < count - 1) {
                             fieldPositions[i + 1] = fieldPositions[i] + (tables[i] == null
? 0 : (tables[i].getColumns().size() - tables[i].getPKColumns().size()));
                         }
    -                    hashPlans[i] = new HashSubPlan(i, subPlans[i], optimized ? null :
hashExpressions, joinSpec.isSingleValueOnly(), keyRangeLhsExpression, keyRangeRhsExpression);
    +                    boolean usePersistentCache = joinTable.getStatement().getHint().hasHint(Hint.USE_PERSISTENT_CACHE);
    --- End diff --
    
    We can make "usePersistentCache" a member of QueryCompiler and initialize it in the beginning
just like "noChildParentJoinOptimization".


---

Mime
View raw message