phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ChinmaySKulkarni <...@git.apache.org>
Subject [GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...
Date Tue, 03 Apr 2018 21:07:20 GMT
Github user ChinmaySKulkarni commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/295#discussion_r178962419
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogCreationOnConnectionIT.java
---
    @@ -0,0 +1,533 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.end2end;
    +
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hbase.HBaseTestingUtility;
    +import org.apache.hadoop.hbase.HConstants;
    +import org.apache.hadoop.hbase.TableName;
    +import org.apache.phoenix.coprocessor.MetaDataProtocol;
    +import org.apache.phoenix.exception.SQLExceptionCode;
    +import org.apache.phoenix.exception.UpgradeRequiredException;
    +import org.apache.phoenix.jdbc.PhoenixEmbeddedDriver;
    +import org.apache.phoenix.jdbc.PhoenixTestDriver;
    +import org.apache.phoenix.query.*;
    +import org.apache.phoenix.util.ReadOnlyProps;
    +import org.apache.phoenix.util.UpgradeUtil;
    +import org.junit.After;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +import java.io.IOException;
    +import java.sql.Connection;
    +import java.sql.SQLException;
    +import java.util.*;
    +
    +import static org.junit.Assert.*;
    +
    +public class SystemCatalogCreationOnConnectionIT {
    +    private HBaseTestingUtility testUtil = null;
    +    private Set<String> hbaseTables;
    +    private static boolean setOldTimestampToInduceUpgrade = false;
    +    private static int countUpgradeAttempts;
    +    private static final String PHOENIX_NAMESPACE_MAPPED_SYSTEM_CATALOG = "SYSTEM:CATALOG";
    +    private static final String PHOENIX_SYSTEM_CATALOG = "SYSTEM.CATALOG";
    +    private static final String EXECUTE_UPGRADE_COMMAND = "EXECUTE UPGRADE";
    +
    +    private static final Set<String> PHOENIX_SYSTEM_TABLES = new HashSet<>(Arrays.asList(
    +      "SYSTEM.CATALOG", "SYSTEM.SEQUENCE", "SYSTEM.STATS", "SYSTEM.FUNCTION",
    +      "SYSTEM.MUTEX"));
    +
    +    private static final Set<String> PHOENIX_NAMESPACE_MAPPED_SYSTEM_TABLES = new
HashSet<>(
    +      Arrays.asList("SYSTEM:CATALOG", "SYSTEM:SEQUENCE", "SYSTEM:STATS", "SYSTEM:FUNCTION",
    +        "SYSTEM:MUTEX"));
    +
    +    private static class PhoenixSysCatCreationServices extends ConnectionQueryServicesImpl
{
    +
    +        public PhoenixSysCatCreationServices(QueryServices services, PhoenixEmbeddedDriver.ConnectionInfo
connectionInfo, Properties info) {
    +            super(services, connectionInfo, info);
    +        }
    +
    +        @Override
    +        protected void setUpgradeRequired() {
    +            super.setUpgradeRequired();
    +            countUpgradeAttempts++;
    +        }
    +
    +        @Override
    +        protected long getSystemTableVersion() {
    +            if (setOldTimestampToInduceUpgrade) {
    +                // Return the next lower version where an upgrade was performed to induce
setting the upgradeRequired flag
    +                return MetaDataProtocol.getPriorUpgradeVersion();
    +            }
    +            return MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP;
    +        }
    +    }
    +    
    +    public static class PhoenixSysCatCreationTestingDriver extends PhoenixTestDriver
{
    +        private ConnectionQueryServices cqs;
    +        private final ReadOnlyProps overrideProps;
    +    
    +        public PhoenixSysCatCreationTestingDriver(ReadOnlyProps props) {
    +            overrideProps = props;
    +        }
    +    
    +        @Override // public for testing
    +        public synchronized ConnectionQueryServices getConnectionQueryServices(String
url, Properties info) throws SQLException {
    +            if (cqs == null) {
    +                cqs = new PhoenixSysCatCreationServices(new QueryServicesTestImpl(getDefaultProps(),
overrideProps), ConnectionInfo.create(url), info);
    +                cqs.init(url, info);
    +            }
    +            return cqs;
    +        }
    +    
    +        // NOTE: Do not use this if you want to try re-establishing a connection from
the client using a previously
    +        // used ConnectionQueryServices instance. This is used only in cases where we
need to test server-side
    +        // changes and don't care about client-side properties set from the init method.
    +        // Reset the Connection Query Services instance so we can create a new connection
to the cluster
    +        public void resetCQS() {
    +            cqs = null;
    +        }
    +    }
    +
    +
    +    @Before
    +    public void resetVariables() {
    +        setOldTimestampToInduceUpgrade = false;
    +        countUpgradeAttempts = 0;
    +    }
    +
    +    @After
    +    public void tearDownMiniCluster() {
    +        try {
    +            if (testUtil != null) {
    +                testUtil.shutdownMiniCluster();
    +                testUtil = null;
    +            }
    +        } catch (Exception e) {
    +            // ignore
    +        }
    +    }
    +
    +
    --- End diff --
    
    Thanks!


---

Mime
View raw message