phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ChinmaySKulkarni <>
Subject [GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...
Date Tue, 03 Apr 2018 21:02:08 GMT
Github user ChinmaySKulkarni commented on a diff in the pull request:
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/
    @@ -2643,6 +2661,26 @@ public void upgradeSystemTables(final String url, final Properties
props) throws
                 try {
    +                // HBase Namespace SYSTEM is created by {@link ensureSystemTablesMigratedToSystemNamespace(ReadOnlyProps)}
    +                // This statement will create its entry in SYSCAT table, so that GRANT/REVOKE
commands can work
    +                // with SYSTEM Namespace. (See PHOENIX-4227
    +                if (SchemaUtil.isNamespaceMappingEnabled(PTableType.SYSTEM,
    +                  ConnectionQueryServicesImpl.this.getProps())) {
    --- End diff --
    @JamesRTaylor Makes sense. Note that we don't **already** have the SYSMUTEX lock at this
point (referring to your earlier comment). This is in fact necessary to avoid an _UpgradeInProgressException_
from _ensureSystemTablesMigratedToSystemNamespace_ since we try to acquire the SYSMUTEX lock
inside here as well. So, moving _ensureSystemTablesMigratedToSystemNamespace_ to this place
shouldn't lead to any problems.


View raw message