From dev-return-50527-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Mar 29 08:42:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B9707180645 for ; Thu, 29 Mar 2018 08:42:08 +0200 (CEST) Received: (qmail 58534 invoked by uid 500); 29 Mar 2018 06:42:02 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 58470 invoked by uid 99); 29 Mar 2018 06:42:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Mar 2018 06:42:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 11B7BC07C0 for ; Thu, 29 Mar 2018 06:42:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.811 X-Spam-Level: X-Spam-Status: No, score=-109.811 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id AofyQWedUkon for ; Thu, 29 Mar 2018 06:42:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CFC2B5F2F1 for ; Thu, 29 Mar 2018 06:42:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 57AEBE00C9 for ; Thu, 29 Mar 2018 06:42:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 14B2F255EA for ; Thu, 29 Mar 2018 06:42:00 +0000 (UTC) Date: Thu, 29 Mar 2018 06:42:00 +0000 (UTC) From: "Marcell Ortutay (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (PHOENIX-4679) Exit build-proto.sh if not using protoc v2.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Marcell Ortutay created PHOENIX-4679: ---------------------------------------- Summary: Exit build-proto.sh if not using protoc v2.5.0 Key: PHOENIX-4679 URL: https://issues.apache.org/jira/browse/PHOENIX-4679 Project: Phoenix Issue Type: Improvement Reporter: Marcell Ortutay If you use a version of protoc later than v2.5.0 to regenerate protobufs, you'll get a diff from the current protobuf generated code, even if you made no changes to the .proto files. I assume this is undesirable, so it would be nice if the build-proto.sh script warned people about this. The following check would do this: {code:java} if [[ `protoc --version` != *"2.5.0"* ]]; then echo "Must use protoc version 2.5.0" exit 1 fi {code} If this seems useful I can submit a PR to implement this -- This message was sent by Atlassian JIRA (v7.6.3#76005)