From dev-return-50211-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri Mar 16 22:24:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1F869180608 for ; Fri, 16 Mar 2018 22:24:02 +0100 (CET) Received: (qmail 5365 invoked by uid 500); 16 Mar 2018 21:24:02 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 5353 invoked by uid 99); 16 Mar 2018 21:24:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Mar 2018 21:24:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id AF64E1A0828 for ; Fri, 16 Mar 2018 21:24:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id sOrlJqmX6Dp0 for ; Fri, 16 Mar 2018 21:24:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CDF6E5F1B3 for ; Fri, 16 Mar 2018 21:24:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 570CDE021B for ; Fri, 16 Mar 2018 21:24:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1976921286 for ; Fri, 16 Mar 2018 21:24:00 +0000 (UTC) Date: Fri, 16 Mar 2018 21:24:00 +0000 (UTC) From: "Thomas D'Silva (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4505) IndexHalfStoreFileReaderGenerator.preStoreScannerOpen does not close the passed in KeyValueScanner while creating and returning a new scanner MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402554#comment-16402554 ] Thomas D'Silva commented on PHOENIX-4505: ----------------------------------------- Attaching last patch (hopefully), I added a null check before closing. > IndexHalfStoreFileReaderGenerator.preStoreScannerOpen does not close the passed in KeyValueScanner while creating and returning a new scanner > --------------------------------------------------------------------------------------------------------------------------------------------- > > Key: PHOENIX-4505 > URL: https://issues.apache.org/jira/browse/PHOENIX-4505 > Project: Phoenix > Issue Type: Bug > Reporter: Thomas D'Silva > Assignee: Thomas D'Silva > Priority: Major > Attachments: PHOENIX-4505-v2.patch, PHOENIX-4505-v3.patch, PHOENIX-4505-v4-5.x-HBase-2.0.patch, PHOENIX-4505-v4-master.patch, PHOENIX-4505.patch > > > [~jamestaylor] > preCompactScannerOpen also does not close the InternalScanner that is passed in before creating and returning a new scanner, does that scanner need to be closed as well? -- This message was sent by Atlassian JIRA (v7.6.3#76005)