From dev-return-49860-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Sat Mar 3 05:12:11 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EDFB8180679 for ; Sat, 3 Mar 2018 05:12:10 +0100 (CET) Received: (qmail 84302 invoked by uid 500); 3 Mar 2018 04:12:09 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 83793 invoked by uid 99); 3 Mar 2018 04:12:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Mar 2018 04:12:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1207218038A for ; Sat, 3 Mar 2018 04:12:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Y8x7_Flh1FFd for ; Sat, 3 Mar 2018 04:12:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 525E95FC18 for ; Sat, 3 Mar 2018 04:12:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C1659E0950 for ; Sat, 3 Mar 2018 04:12:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0125C247B4 for ; Sat, 3 Mar 2018 04:12:01 +0000 (UTC) Date: Sat, 3 Mar 2018 04:12:01 +0000 (UTC) From: "Thomas D'Silva (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (PHOENIX-4418) UPPER() and LOWER() functions should be locale-aware MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384463#comment-16384463 ] Thomas D'Silva edited comment on PHOENIX-4418 at 3/3/18 4:11 AM: ----------------------------------------------------------------- [~shehzaadn] There were some test failures in the precommit build that look like they are related to this change (IndexToolIT, IndexExtendedIT). Can you please take a look? see https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-PHOENIX-Build/1782/#showFailuresLink was (Author: tdsilva): [~shehzaadn] There were some test failures in the precommitt that look like they are related to this change (IndexToolIT, IndexExtendedIT). Can you please take a look? see https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-PHOENIX-Build/1782/#showFailuresLink > UPPER() and LOWER() functions should be locale-aware > ---------------------------------------------------- > > Key: PHOENIX-4418 > URL: https://issues.apache.org/jira/browse/PHOENIX-4418 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 4.13.0 > Reporter: Shehzaad Nakhoda > Assignee: Shehzaad Nakhoda > Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4418_v1.patch > > > Correct conversion of a string to upper or lower case depends on Locale. > Java's upper case and lower case conversion routines allow passing in a locale. > It should be possible to pass in a locale to UPPER() and LOWER() in Phoenix so that locale-specific case conversion can be supported in Phoenix. > See java.lang.String#toUpperCase() -- This message was sent by Atlassian JIRA (v7.6.3#76005)