From dev-return-50411-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org  Fri Mar 23 02:18:40 2018
Return-Path: <dev-return-50411-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 5EC3A180676
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 23 Mar 2018 02:18:40 +0100 (CET)
Received: (qmail 74833 invoked by uid 500); 23 Mar 2018 01:18:39 -0000
Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@phoenix.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@phoenix.apache.org>
List-Post: <mailto:dev@phoenix.apache.org>
List-Id: <dev.phoenix.apache.org>
Reply-To: dev@phoenix.apache.org
Delivered-To: mailing list dev@phoenix.apache.org
Received: (qmail 74822 invoked by uid 99); 23 Mar 2018 01:18:38 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Mar 2018 01:18:38 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D456DF6766; Fri, 23 Mar 2018 01:18:37 +0000 (UTC)
From: ChinmaySKulkarni <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-295-phoenix@git.apache.org>
In-Reply-To: <git-pr-295-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...
Content-Type: text/plain
Message-Id: <20180323011837.D456DF6766@git1-us-west.apache.org>
Date: Fri, 23 Mar 2018 01:18:37 +0000 (UTC)

Github user ChinmaySKulkarni commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/295#discussion_r176617368
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ---
    @@ -2405,16 +2413,26 @@ public Void call() throws Exception {
                                 openConnection();
                                 hConnectionEstablished = true;
                                 boolean isDoNotUpgradePropSet = UpgradeUtil.isNoUpgradeSet(props);
    +                            boolean doesSystemCatalogAlreadyExist = false;
    --- End diff --
    
    @JamesRTaylor @twdsilva also, do we really want to avoid calling ensureTableCreated from createTable in case it is a system table? Apart from actually ensuring that the table is created or not and the client-server compatibility checks, this method also modifies the table according to a new descriptor (I don't have enough background as to why we do this here). Any advice guys?


---