From dev-return-50049-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Sat Mar 10 06:43:41 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id AD78A180651 for ; Sat, 10 Mar 2018 06:43:40 +0100 (CET) Received: (qmail 99723 invoked by uid 500); 10 Mar 2018 05:43:39 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 99712 invoked by uid 99); 10 Mar 2018 05:43:38 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Mar 2018 05:43:38 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0DDDAE0187; Sat, 10 Mar 2018 05:43:37 +0000 (UTC) From: JamesRTaylor To: dev@phoenix.apache.org Reply-To: dev@phoenix.apache.org References: In-Reply-To: Subject: [GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func... Content-Type: text/plain Message-Id: <20180310054338.0DDDAE0187@git1-us-west.apache.org> Date: Sat, 10 Mar 2018 05:43:37 +0000 (UTC) Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/294#discussion_r173612840 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayRemoveFunction.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.phoenix.expression.function; + +import java.util.List; + +import org.apache.hadoop.hbase.io.ImmutableBytesWritable; +import org.apache.phoenix.expression.Expression; +import org.apache.phoenix.parse.FunctionParseNode; +import org.apache.phoenix.schema.SortOrder; +import org.apache.phoenix.schema.TypeMismatchException; +import org.apache.phoenix.schema.types.PArrayDataTypeDecoder; +import org.apache.phoenix.schema.types.PArrayDataTypeEncoder; +import org.apache.phoenix.schema.types.PBinaryArray; +import org.apache.phoenix.schema.types.PDataType; +import org.apache.phoenix.schema.types.PVarbinary; +import org.apache.phoenix.schema.types.PVarbinaryArray; + +@FunctionParseNode.BuiltInFunction(name = ArrayRemoveFunction.NAME, args = { + @FunctionParseNode.Argument(allowedTypes = { PBinaryArray.class, PVarbinaryArray.class }), + @FunctionParseNode.Argument(allowedTypes = { PVarbinary.class }, defaultValue = "null") }) +public class ArrayRemoveFunction extends ArrayModifierFunction { + + public static final String NAME = "ARRAY_REMOVE"; + + public ArrayRemoveFunction() { + } + + public ArrayRemoveFunction(List children) throws TypeMismatchException { + super(children); + } + + @Override + protected boolean modifierFunction(ImmutableBytesWritable ptr, int length, int offset, byte[] arrayBytes, + PDataType baseType, int arrayLength, Integer maxLength, Expression arrayExp) { + SortOrder sortOrder = arrayExp.getSortOrder(); + + if (ptr.getLength() == 0 || arrayBytes.length == 0) { + ptr.set(arrayBytes, offset, length); + return true; + } + + PArrayDataTypeEncoder arrayDataTypeEncoder = new PArrayDataTypeEncoder(baseType, sortOrder); + + for (int arrayIndex = 0; arrayIndex < arrayLength; arrayIndex++) { + ImmutableBytesWritable ptr2 = new ImmutableBytesWritable(arrayBytes, offset, length); + PArrayDataTypeDecoder.positionAtArrayElement(ptr2, arrayIndex, baseType, maxLength); + if (baseType.compareTo(ptr2, sortOrder, ptr, sortOrder, baseType) != 0) { --- End diff -- This looks good. Can you make sure you have tests around removing an element from an array where the element type is slightly different than the array element type? For example, removing an int from a long array or removing a long from a decimal array? ---