phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcell Ortutay (JIRA)" <j...@apache.org>
Subject [jira] [Created] (PHOENIX-4679) Exit build-proto.sh if not using protoc v2.5.0
Date Thu, 29 Mar 2018 06:42:00 GMT
Marcell Ortutay created PHOENIX-4679:
----------------------------------------

             Summary: Exit build-proto.sh if not using protoc v2.5.0
                 Key: PHOENIX-4679
                 URL: https://issues.apache.org/jira/browse/PHOENIX-4679
             Project: Phoenix
          Issue Type: Improvement
            Reporter: Marcell Ortutay


If you use a version of protoc later than v2.5.0 to regenerate protobufs, you'll get a diff
from the current protobuf generated code, even if you made no changes to the .proto files.
I assume this is undesirable, so it would be nice if the build-proto.sh script warned people
about this. The following check would do this:
{code:java}
if [[ `protoc --version` != *"2.5.0"* ]]; then
  echo "Must use protoc version 2.5.0"
  exit 1
fi
{code}
If this seems useful I can submit a PR to implement this



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message