phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4644) Array modification functions should require two arguments
Date Sat, 10 Mar 2018 00:55:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393898#comment-16393898
] 

Hudson commented on PHOENIX-4644:
---------------------------------

SUCCESS: Integrated in Jenkins build PreCommit-PHOENIX-Build #1797 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/1797/])
PHOENIX-4644 Array modification functions should require two arguments (jtaylor: rev d2715101e10ce2a5b3dfbaf8a8f23997fbc6ec58)
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayAppendFunctionIT.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayConcatFunction.java
* (add) phoenix-core/src/main/java/org/apache/phoenix/parse/ArrayModifierParseNode.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/parse/FunctionParseNode.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayModifierFunction.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/util/ExpressionUtil.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayAppendFunction.java
* (edit) phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayPrependFunction.java


> Array modification functions should require two arguments
> ---------------------------------------------------------
>
>                 Key: PHOENIX-4644
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4644
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 4.14.0, 5.0.0
>
>         Attachments: PHOENIX-4644_v1.patch, PHOENIX-4644_v2.patch
>
>
> ARRAY_APPEND, ARRAY_PREPEND, and ARRAY_CAT should require two arguments. Also, if the
second argument is null, we need to make sure not to have the entire expression return null
(but instead it should return the first argument). To accomplish this, we need to have a ParseNode
that overrides the method controlling this and ensure it's used for these functions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message