phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4644) Array modification functions should require two arguments
Date Fri, 09 Mar 2018 23:04:00 GMT


James Taylor commented on PHOENIX-4644:

Thanks for the review, [~tdsilva]. I attached a v2 patch that adds tests and fixes the NPE
(considerably harder than I expected...)

> Array modification functions should require two arguments
> ---------------------------------------------------------
>                 Key: PHOENIX-4644
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 4.14.0
>         Attachments: PHOENIX-4644_v1.patch, PHOENIX-4644_v2.patch
> ARRAY_APPEND, ARRAY_PREPEND, and ARRAY_CAT should require two arguments. Also, if the
second argument is null, we need to make sure not to have the entire expression return null
(but instead it should return the first argument). To accomplish this, we need to have a ParseNode
that overrides the method controlling this and ensure it's used for these functions.

This message was sent by Atlassian JIRA

View raw message