phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #294: PHOENIX-4643 Implement ARRAY_REMOVE built in func...
Date Sat, 10 Mar 2018 05:43:37 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/294#discussion_r173612840
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayRemoveFunction.java
---
    @@ -0,0 +1,79 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.phoenix.expression.function;
    +
    +import java.util.List;
    +
    +import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
    +import org.apache.phoenix.expression.Expression;
    +import org.apache.phoenix.parse.FunctionParseNode;
    +import org.apache.phoenix.schema.SortOrder;
    +import org.apache.phoenix.schema.TypeMismatchException;
    +import org.apache.phoenix.schema.types.PArrayDataTypeDecoder;
    +import org.apache.phoenix.schema.types.PArrayDataTypeEncoder;
    +import org.apache.phoenix.schema.types.PBinaryArray;
    +import org.apache.phoenix.schema.types.PDataType;
    +import org.apache.phoenix.schema.types.PVarbinary;
    +import org.apache.phoenix.schema.types.PVarbinaryArray;
    +
    +@FunctionParseNode.BuiltInFunction(name = ArrayRemoveFunction.NAME, args = {
    +		@FunctionParseNode.Argument(allowedTypes = { PBinaryArray.class, PVarbinaryArray.class
}),
    +		@FunctionParseNode.Argument(allowedTypes = { PVarbinary.class }, defaultValue = "null")
})
    +public class ArrayRemoveFunction extends ArrayModifierFunction {
    +
    +	public static final String NAME = "ARRAY_REMOVE";
    +
    +	public ArrayRemoveFunction() {
    +	}
    +
    +	public ArrayRemoveFunction(List<Expression> children) throws TypeMismatchException
{
    +		super(children);
    +	}
    +
    +	@Override
    +	protected boolean modifierFunction(ImmutableBytesWritable ptr, int length, int offset,
byte[] arrayBytes,
    +			PDataType baseType, int arrayLength, Integer maxLength, Expression arrayExp) {
    +		SortOrder sortOrder = arrayExp.getSortOrder();
    +
    +		if (ptr.getLength() == 0 || arrayBytes.length == 0) {
    +			ptr.set(arrayBytes, offset, length);
    +			return true;
    +		}
    +
    +		PArrayDataTypeEncoder arrayDataTypeEncoder = new PArrayDataTypeEncoder(baseType, sortOrder);
    +
    +		for (int arrayIndex = 0; arrayIndex < arrayLength; arrayIndex++) {
    +			ImmutableBytesWritable ptr2 = new ImmutableBytesWritable(arrayBytes, offset, length);
    +			PArrayDataTypeDecoder.positionAtArrayElement(ptr2, arrayIndex, baseType, maxLength);
    +			if (baseType.compareTo(ptr2, sortOrder, ptr, sortOrder, baseType) != 0) {
    --- End diff --
    
    This looks good. Can you make sure you have tests around removing an element from an array
where the element type is slightly different than the array element type? For example, removing
an int from a long array or removing a long from a decimal array?


---

Mime
View raw message