From dev-return-49544-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Sat Feb 17 02:42:10 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 85C7D180647 for ; Sat, 17 Feb 2018 02:42:09 +0100 (CET) Received: (qmail 85418 invoked by uid 500); 17 Feb 2018 01:42:08 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 85406 invoked by uid 99); 17 Feb 2018 01:42:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 Feb 2018 01:42:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D49751A00E4 for ; Sat, 17 Feb 2018 01:42:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id RfAfWgBVBjgg for ; Sat, 17 Feb 2018 01:42:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C118E5F473 for ; Sat, 17 Feb 2018 01:42:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1346DE0352 for ; Sat, 17 Feb 2018 01:42:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DC60E21E6A for ; Sat, 17 Feb 2018 01:42:02 +0000 (UTC) Date: Sat, 17 Feb 2018 01:42:02 +0000 (UTC) From: "Maryann Xue (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (PHOENIX-4611) Not nullable column impact on join query plans MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4611?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 368052#comment-16368052 ]=20 Maryann Xue edited comment on PHOENIX-4611 at 2/17/18 1:41 AM: --------------------------------------------------------------- Sorry for the confusion, [~jamestaylor].=C2=A0Nothing would change in the p= lan other than the group-by expressions being turned around. The changed pl= an is due to the group-by only and has nothing to do with join queries. It = is only that it happened to be a join query, and the group-by expressions w= ould have been=C2=A0re-ordered=C2=A0the same way=C2=A0had=C2=A0it not been = a join query. That said, this test is a good example of a potential optimization filed as= =C2=A0PHOENIX-4618. I'll go ahead and revert the commit. was (Author: maryannxue): Sorry for the confusion, [~jamestaylor].=C2=A0Nothing would change in the p= lan other than the group-by expressions being turned around. Although we co= uld have implemented this query more efficiently if we implemented PHOENIX-= 4618. I'll go ahead and revert the commit. > Not nullable column impact on join query plans > ---------------------------------------------- > > Key: PHOENIX-4611 > URL: https://issues.apache.org/jira/browse/PHOENIX-4611 > Project: Phoenix > Issue Type: Bug > Reporter: James Taylor > Priority: Major > > With PHOENIX-2566, there's a subtle change in projected tables in that a = column may end up being not nullable where as before it was nullable when t= he family name is not null. I've kept the old behavior with [this|https://g= it-wip-us.apache.org/repos/asf?p=3Dphoenix.git;a=3Dblobdiff;f=3Dphoenix-cor= e/src/main/java/org/apache/phoenix/compile/TupleProjectionCompiler.java;h= =3Dfccded2a896855a2a01d727b992f954a1d3fa8ab;hp=3Dd0b900c1a9c21609b890653074= 33a0d37b12b72a;hb=3D82ba1417fdd69a0ac57cbcf2f2327d4aa371bcd9;hpb=3De126dd1d= da5aa80e8296d3b0c84736b22b658999] commit, but would you mind confirming wha= t the right thing to do is, [~maryannxue]? > Without this change, the explain plan changes in SortMergeJoinMoreIT.test= Bug2894() and the assert fails. Looks like the compiler ends up changing th= e row ordering. -- This message was sent by Atlassian JIRA (v7.6.3#76005)