From dev-return-49539-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Sat Feb 17 00:31:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 25EEC180647 for ; Sat, 17 Feb 2018 00:31:04 +0100 (CET) Received: (qmail 19306 invoked by uid 500); 16 Feb 2018 23:31:04 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 19295 invoked by uid 99); 16 Feb 2018 23:31:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Feb 2018 23:31:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A64D7C0238 for ; Fri, 16 Feb 2018 23:31:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id PqdkCD5fr5Jf for ; Fri, 16 Feb 2018 23:31:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4970F5F522 for ; Fri, 16 Feb 2018 23:31:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 39ECFE0230 for ; Fri, 16 Feb 2018 23:31:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 369EF21E60 for ; Fri, 16 Feb 2018 23:31:00 +0000 (UTC) Date: Fri, 16 Feb 2018 23:31:00 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4611) Not nullable column impact on join query plans MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368018#comment-16368018 ] James Taylor commented on PHOENIX-4611: --------------------------------------- bq. BTW, do we have any test facility that checks an unordered result-set? It'll be useful for such tests. See BaseTest.assertValuesEqualsResultSet() > Not nullable column impact on join query plans > ---------------------------------------------- > > Key: PHOENIX-4611 > URL: https://issues.apache.org/jira/browse/PHOENIX-4611 > Project: Phoenix > Issue Type: Bug > Reporter: James Taylor > Priority: Major > > With PHOENIX-2566, there's a subtle change in projected tables in that a column may end up being not nullable where as before it was nullable when the family name is not null. I've kept the old behavior with [this|https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=blobdiff;f=phoenix-core/src/main/java/org/apache/phoenix/compile/TupleProjectionCompiler.java;h=fccded2a896855a2a01d727b992f954a1d3fa8ab;hp=d0b900c1a9c21609b89065307433a0d37b12b72a;hb=82ba1417fdd69a0ac57cbcf2f2327d4aa371bcd9;hpb=e126dd1dda5aa80e8296d3b0c84736b22b658999] commit, but would you mind confirming what the right thing to do is, [~maryannxue]? > Without this change, the explain plan changes in SortMergeJoinMoreIT.testBug2894() and the assert fails. Looks like the compiler ends up changing the row ordering. -- This message was sent by Atlassian JIRA (v7.6.3#76005)