From dev-return-49525-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri Feb 16 19:45:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BECAB18067B for ; Fri, 16 Feb 2018 19:45:04 +0100 (CET) Received: (qmail 39403 invoked by uid 500); 16 Feb 2018 18:45:03 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 39392 invoked by uid 99); 16 Feb 2018 18:45:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Feb 2018 18:45:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3593DC1360 for ; Fri, 16 Feb 2018 18:45:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id V0p6jWjUv8ZY for ; Fri, 16 Feb 2018 18:45:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E1E3E5F576 for ; Fri, 16 Feb 2018 18:45:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BEA60E0230 for ; Fri, 16 Feb 2018 18:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3370821E61 for ; Fri, 16 Feb 2018 18:45:00 +0000 (UTC) Date: Fri, 16 Feb 2018 18:45:00 +0000 (UTC) From: "Maryann Xue (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4585) Prune local index regions used for join queries MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4585?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 367713#comment-16367713 ]=20 Maryann Xue commented on PHOENIX-4585: -------------------------------------- {quote}How about adding a UNION ALL test to make sure we're doing the pruni= ng there too?{quote} Sure. I'll go ahead add a test. {quote} - If you want to combine this with=C2=A0PHOENIX-4614, that's fine t= oo if you think you can get to it soon.{quote} I don't know exactly what PHOENIX-4614 would take, plus PHOENIX-4614 has li= ttle user impact, so I'll commit this issue first when it's ready. {quote}What happens in that optimize call for joins & union all (since it s= eems that the optimization happens during compile)? Should we clean that up= (maybe in a separate JIRA)?{quote} Yes, we should pull that "optimize" logic out from compile(). I just opened= PHOENIX-4616. It will be quite an mount of work. {quote} Also related to the above, we need to ensure that tableRefs returns= the original data tables and not the index tables or we won't send over un= committed data when transactions are used. Do you think that's happening?{q= uote} Not sure, I'll check. If not, it will either depend on PHOENIX-4616, or for= a quick fix, we can add a "no index" hint to the {{stmt}} here to make sur= e we get all data tables. I'll open a JIRA for that either way. > Prune local index regions used for join queries > ----------------------------------------------- > > Key: PHOENIX-4585 > URL: https://issues.apache.org/jira/browse/PHOENIX-4585 > Project: Phoenix > Issue Type: Improvement > Reporter: James Taylor > Assignee: Maryann Xue > Priority: Major > Attachments: PHOENIX-4585.patch > > > Some remaining work from PHOENIX-3941: we currently do not capture the da= ta plan as part of the index plan due to the way in which we rewrite the st= atement during join processing. See comment here for more detail: https://i= ssues.apache.org/jira/browse/PHOENIX-3941?focusedCommentId=3D16351017&page= =3Dcom.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment= -16351017 -- This message was sent by Atlassian JIRA (v7.6.3#76005)