From dev-return-49658-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri Feb 23 02:21:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 441BE18064E for ; Fri, 23 Feb 2018 02:21:05 +0100 (CET) Received: (qmail 17163 invoked by uid 500); 23 Feb 2018 01:21:04 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 17151 invoked by uid 99); 23 Feb 2018 01:21:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Feb 2018 01:21:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B83F81A073D for ; Fri, 23 Feb 2018 01:21:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id wIdZqVRZgoH2 for ; Fri, 23 Feb 2018 01:21:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B61385F24E for ; Fri, 23 Feb 2018 01:21:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AAB25E0366 for ; Fri, 23 Feb 2018 01:21:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 86EAA2714F for ; Fri, 23 Feb 2018 01:21:00 +0000 (UTC) Date: Fri, 23 Feb 2018 01:21:00 +0000 (UTC) From: "Vincent Poon (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (PHOENIX-4530) Do not collect delete markers during major compaction of table with disabled mutable indexes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Poon updated PHOENIX-4530: ---------------------------------- Attachment: PHOENIX-4530.4.x-HBase-1.1.v2.patch PHOENIX-4530.4.x-HBase-0.98.v2.patch > Do not collect delete markers during major compaction of table with disabled mutable indexes > -------------------------------------------------------------------------------------------- > > Key: PHOENIX-4530 > URL: https://issues.apache.org/jira/browse/PHOENIX-4530 > Project: Phoenix > Issue Type: Improvement > Environment: > Reporter: James Taylor > Assignee: Vincent Poon > Priority: Major > Attachments: PHOENIX-4530.4.x-HBase-0.98.v2.patch, PHOENIX-4530.4.x-HBase-1.1.v2.patch, PHOENIX-4530.master.v1.patch, PHOENIX-4530.master.v2.patch > > > If major compaction occurs on a table with mutable indexes that have the INDEX_DISABLE_TIMESTAMP set, we currently permanently disable the index, forcing it to be manually rebuilt from scratch. This is to prevent it from potentially being corrupted as we need the delete markers to remain in order to guarantee the data table and index table remain in sync. > An alternate approach (mentioned by [~ankit@apache.org] during review) is to detect this case in a pre-compaction hook and set the compaction up so that delete markers are not removed. This would have the advantage that we wouldn't have to permanently disable the index and rebuild it from scratch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)