From dev-return-49520-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri Feb 16 07:19:11 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id ACF94180647 for ; Fri, 16 Feb 2018 07:19:10 +0100 (CET) Received: (qmail 6741 invoked by uid 500); 16 Feb 2018 06:19:09 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 6730 invoked by uid 99); 16 Feb 2018 06:19:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Feb 2018 06:19:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 25CAC180111 for ; Fri, 16 Feb 2018 06:19:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id rQ2LNOlI4HEt for ; Fri, 16 Feb 2018 06:19:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E65B15F18D for ; Fri, 16 Feb 2018 06:19:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2E5E8E0231 for ; Fri, 16 Feb 2018 06:19:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0611621E5E for ; Fri, 16 Feb 2018 06:19:02 +0000 (UTC) Date: Fri, 16 Feb 2018 06:19:02 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366496#comment-16366496 ] James Taylor edited comment on PHOENIX-4333 at 2/16/18 6:18 AM: ---------------------------------------------------------------- Attached WIP patch with all the above implemented. Still need to fix ExplainPlanWithStatsEnabledIT. Here are the current failures: {code} [ERROR] Tests run: 24, Failures: 3, Errors: 2, Skipped: 0, Time elapsed: 64.285 s <<< FAILURE! - in org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT [ERROR] testSelectQueriesWithStatsForParallelizationOn(org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT) Time elapsed: 2.387 s <<< FAILURE! java.lang.AssertionError: expected:<10> but was:<9> at org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testSelectQueriesWithFilters(ExplainPlanWithStatsEnabledIT.java:669) at org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testSelectQueriesWithStatsForParallelizationOn(ExplainPlanWithStatsEnabledIT.java:629) [ERROR] testBytesRowsForSelectWhenKeyOutOfRange(org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT) Time elapsed: 0.012 s <<< ERROR! java.lang.NullPointerException at org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testBytesRowsForSelectWhenKeyOutOfRange(ExplainPlanWithStatsEnabledIT.java:116) [ERROR] testBytesRowsForSelectOnTenantViews(org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT) Time elapsed: 4.654 s <<< FAILURE! java.lang.AssertionError: expected:<2000> but was: at org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testBytesRowsForSelectOnTenantViews(ExplainPlanWithStatsEnabledIT.java:426) [ERROR] testSelectQueriesWithStatsForParallelizationOff(org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT) Time elapsed: 2.322 s <<< FAILURE! java.lang.AssertionError: expected:<10> but was:<9> at org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testSelectQueriesWithFilters(ExplainPlanWithStatsEnabledIT.java:669) at org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testSelectQueriesWithStatsForParallelizationOff(ExplainPlanWithStatsEnabledIT.java:624) [ERROR] testEstimatesForAggregateQueries(org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT) Time elapsed: 2.324 s <<< ERROR! java.lang.NullPointerException at org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testEstimatesForAggregateQueries(ExplainPlanWithStatsEnabledIT.java:560) [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 155.149 s - in org.apache.phoenix.end2end.TenantSpecificTablesDDLIT [INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 149.108 s - in org.apache.phoenix.end2end.TenantSpecificTablesDMLIT [INFO] Tests run: 52, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 280.504 s - in org.apache.phoenix.end2end.ViewIT [INFO] [INFO] Results: [INFO] [ERROR] Failures: [ERROR] ExplainPlanWithStatsEnabledIT.testBytesRowsForSelectOnTenantViews:426 expected:<2000> but was: [ERROR] ExplainPlanWithStatsEnabledIT.testSelectQueriesWithStatsForParallelizationOff:624->testSelectQueriesWithFilters:669 expected:<10> but was:<9> [ERROR] ExplainPlanWithStatsEnabledIT.testSelectQueriesWithStatsForParallelizationOn:629->testSelectQueriesWithFilters:669 expected:<10> but was:<9> [ERROR] Errors: [ERROR] ExplainPlanWithStatsEnabledIT.testBytesRowsForSelectWhenKeyOutOfRange:116 NullPointer [ERROR] ExplainPlanWithStatsEnabledIT.testEstimatesForAggregateQueries:560 NullPointer [INFO] {code} was (Author: jamestaylor): Attached WIP patch with all the above implemented. Still need to fix ExplainPlanWithStatsEnabledIT. > Stats - Incorrect estimate when stats are updated on a tenant specific view > --------------------------------------------------------------------------- > > Key: PHOENIX-4333 > URL: https://issues.apache.org/jira/browse/PHOENIX-4333 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.12.0 > Reporter: Mujtaba Chohan > Assignee: James Taylor > Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4333_test.patch, PHOENIX-4333_v1.patch, PHOENIX-4333_v2.patch, PHOENIX-4333_wip1.patch > > > Consider two tenants A, B with tenant specific view on 2 separate regions/region servers. > {noformat} > Region 1 keys: > A,1 > A,2 > B,1 > Region 2 keys: > B,2 > B,3 > {noformat} > When stats are updated on tenant A view. Querying stats on tenant B view yield partial results (only contains stats for B,1) which are incorrect even though it shows updated timestamp as current. -- This message was sent by Atlassian JIRA (v7.6.3#76005)