phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maryann Xue (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PHOENIX-4611) Not nullable column impact on join query plans
Date Sat, 17 Feb 2018 01:42:02 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368052#comment-16368052
] 

Maryann Xue edited comment on PHOENIX-4611 at 2/17/18 1:41 AM:
---------------------------------------------------------------

Sorry for the confusion, [~jamestaylor]. Nothing would change in the plan other than the
group-by expressions being turned around. The changed plan is due to the group-by only and
has nothing to do with join queries. It is only that it happened to be a join query, and the
group-by expressions would have been re-ordered the same way had it not been a join query.

That said, this test is a good example of a potential optimization filed as PHOENIX-4618.

I'll go ahead and revert the commit.


was (Author: maryannxue):
Sorry for the confusion, [~jamestaylor]. Nothing would change in the plan other than the
group-by expressions being turned around. Although we could have implemented this query more
efficiently if we implemented PHOENIX-4618.

I'll go ahead and revert the commit.

> Not nullable column impact on join query plans
> ----------------------------------------------
>
>                 Key: PHOENIX-4611
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4611
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Priority: Major
>
> With PHOENIX-2566, there's a subtle change in projected tables in that a column may end
up being not nullable where as before it was nullable when the family name is not null. I've
kept the old behavior with [this|https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=blobdiff;f=phoenix-core/src/main/java/org/apache/phoenix/compile/TupleProjectionCompiler.java;h=fccded2a896855a2a01d727b992f954a1d3fa8ab;hp=d0b900c1a9c21609b89065307433a0d37b12b72a;hb=82ba1417fdd69a0ac57cbcf2f2327d4aa371bcd9;hpb=e126dd1dda5aa80e8296d3b0c84736b22b658999]
commit, but would you mind confirming what the right thing to do is, [~maryannxue]?
> Without this change, the explain plan changes in SortMergeJoinMoreIT.testBug2894() and
the assert fails. Looks like the compiler ends up changing the row ordering.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message