phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4611) Not nullable column impact on join query plans
Date Fri, 16 Feb 2018 23:59:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368034#comment-16368034
] 

James Taylor commented on PHOENIX-4611:
---------------------------------------

Yes, it'd be expected that the GROUP BY key order would change. If it changed and forced a
sort downstream, that'd be bad in terms of performance, but not incorrect.

Is the new execution plan as efficient as the old one?

If so, please go ahead and revert the TupleProjectionCompiler change and update the test instead.
Thanks!

> Not nullable column impact on join query plans
> ----------------------------------------------
>
>                 Key: PHOENIX-4611
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4611
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Priority: Major
>
> With PHOENIX-2566, there's a subtle change in projected tables in that a column may end
up being not nullable where as before it was nullable when the family name is not null. I've
kept the old behavior with [this|https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=blobdiff;f=phoenix-core/src/main/java/org/apache/phoenix/compile/TupleProjectionCompiler.java;h=fccded2a896855a2a01d727b992f954a1d3fa8ab;hp=d0b900c1a9c21609b89065307433a0d37b12b72a;hb=82ba1417fdd69a0ac57cbcf2f2327d4aa371bcd9;hpb=e126dd1dda5aa80e8296d3b0c84736b22b658999]
commit, but would you mind confirming what the right thing to do is, [~maryannxue]?
> Without this change, the explain plan changes in SortMergeJoinMoreIT.testBug2894() and
the assert fails. Looks like the compiler ends up changing the row ordering.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message