phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4603) Remove check for table existence in MetaDataClient.createTableInternal()
Date Wed, 14 Feb 2018 01:43:02 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363355#comment-16363355
] 

Hudson commented on PHOENIX-4603:
---------------------------------

SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #39 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/39/])
PHOENIX-4603 Remove check for table existence in (jtaylor: rev 106daa347e89e762c30089023ae8389b95b01fd3)
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/DynamicColumnIT.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/MappingTableDataTypeIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/NamespaceSchemaMappingIT.java


> Remove check for table existence in MetaDataClient.createTableInternal()
> ------------------------------------------------------------------------
>
>                 Key: PHOENIX-4603
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4603
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 4.14.0, 5.1.0
>
>         Attachments: PHOENIX-4603_v1.patch, PHOENIX-4603_v2.patch
>
>
> Found some strange code in that should be removed. If a table is being created but the
HBase metadata already exists, we can't assume one way or the other that it's encoded or not
encoded. It's on the user to supply the correct existing encoding in that case.
> {code}
>                 byte[] tableNameBytes = SchemaUtil.getTableNameAsBytes(schemaName, tableName);
>                 boolean tableExists = true;
>                 try {
>                     HTableDescriptor tableDescriptor = connection.getQueryServices().getTableDescriptor(tableNameBytes);
>                     if (tableDescriptor == null) { // for connectionless
>                         tableExists = false;
>                     }
>                 } catch (org.apache.phoenix.schema.TableNotFoundException e) {
>                     tableExists = false;
>                 }
>                 if (tableExists) {
>                     encodingScheme = NON_ENCODED_QUALIFIERS;
>                     immutableStorageScheme = ONE_CELL_PER_COLUMN;
>                 } else ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message