phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4603) Remove check for table existence in MetaDataClient.createTableInternal()
Date Tue, 13 Feb 2018 22:29:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363147#comment-16363147
] 

James Taylor commented on PHOENIX-4603:
---------------------------------------

Thanks for the review, [~tdsilva]. I uploaded the final version of the patch which fixes a
couple of tests which needed to explicitly disable column encoding.

> Remove check for table existence in MetaDataClient.createTableInternal()
> ------------------------------------------------------------------------
>
>                 Key: PHOENIX-4603
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4603
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 4.14.0
>
>         Attachments: PHOENIX-4603_v1.patch, PHOENIX-4603_v2.patch
>
>
> Found some strange code in that should be removed. If a table is being created but the
HBase metadata already exists, we can't assume one way or the other that it's encoded or not
encoded. It's on the user to supply the correct existing encoding in that case.
> {code}
>                 byte[] tableNameBytes = SchemaUtil.getTableNameAsBytes(schemaName, tableName);
>                 boolean tableExists = true;
>                 try {
>                     HTableDescriptor tableDescriptor = connection.getQueryServices().getTableDescriptor(tableNameBytes);
>                     if (tableDescriptor == null) { // for connectionless
>                         tableExists = false;
>                     }
>                 } catch (org.apache.phoenix.schema.TableNotFoundException e) {
>                     tableExists = false;
>                 }
>                 if (tableExists) {
>                     encodingScheme = NON_ENCODED_QUALIFIERS;
>                     immutableStorageScheme = ONE_CELL_PER_COLUMN;
>                 } else ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message