phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4575) Phoenix metadata KEEP_DELETED_CELLS and VERSIONS should be property driven
Date Wed, 07 Feb 2018 22:58:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356198#comment-16356198
] 

James Taylor commented on PHOENIX-4575:
---------------------------------------

Looks good, except for this change, keep the call to {{scan.setMaxVersions();}}, but just
use the empty argument version of it (b/c we want to process all versions):
{code}
--- a/phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java
@@ -223,7 +223,6 @@ public class UpgradeUtil {
 
         Scan scan = new Scan();
         scan.setRaw(true);
-        scan.setMaxVersions(MetaDataProtocol.DEFAULT_MAX_META_DATA_VERSIONS);
         ResultScanner scanner = null;
         HTableInterface source = null;
         HTableInterface target = null;
@@ -696,7 +695,6 @@ public class UpgradeUtil {
                 boolean success = false;
                 Scan scan = new Scan();
                 scan.setRaw(true);
-                scan.setMaxVersions(MetaDataProtocol.DEFAULT_MAX_META_DATA_VERSIONS);
                 HTableInterface seqTable = conn.getQueryServices().getTable(PhoenixDatabaseMetaData.SYSTEM_SEQUENCE_NAME_BYTES);
                 try {
                     boolean committed = false;
{code}

> Phoenix metadata KEEP_DELETED_CELLS and VERSIONS should be property driven
> --------------------------------------------------------------------------
>
>                 Key: PHOENIX-4575
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4575
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Mujtaba Chohan
>            Assignee: Mujtaba Chohan
>            Priority: Major
>         Attachments: PHOENIX-4575.patch, PHOENIX-4575_v2.patch
>
>
> This is to cater for circumstances where we need to alter state of KEEP_DELETED_CELLS/VERSION
on Phoenix meta tables.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message