phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view
Date Fri, 16 Feb 2018 06:19:02 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366496#comment-16366496
] 

James Taylor edited comment on PHOENIX-4333 at 2/16/18 6:18 AM:
----------------------------------------------------------------

Attached WIP patch with all the above implemented. Still need to fix ExplainPlanWithStatsEnabledIT.
Here are the current failures:
{code}
[ERROR] Tests run: 24, Failures: 3, Errors: 2, Skipped: 0, Time elapsed: 64.285 s <<<
FAILURE! - in org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT
[ERROR] testSelectQueriesWithStatsForParallelizationOn(org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT)
 Time elapsed: 2.387 s  <<< FAILURE!
java.lang.AssertionError: expected:<10> but was:<9>
	at org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testSelectQueriesWithFilters(ExplainPlanWithStatsEnabledIT.java:669)
	at org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testSelectQueriesWithStatsForParallelizationOn(ExplainPlanWithStatsEnabledIT.java:629)

[ERROR] testBytesRowsForSelectWhenKeyOutOfRange(org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT)
 Time elapsed: 0.012 s  <<< ERROR!
java.lang.NullPointerException
	at org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testBytesRowsForSelectWhenKeyOutOfRange(ExplainPlanWithStatsEnabledIT.java:116)

[ERROR] testBytesRowsForSelectOnTenantViews(org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT)
 Time elapsed: 4.654 s  <<< FAILURE!
java.lang.AssertionError: expected:<2000> but was:<null>
	at org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testBytesRowsForSelectOnTenantViews(ExplainPlanWithStatsEnabledIT.java:426)

[ERROR] testSelectQueriesWithStatsForParallelizationOff(org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT)
 Time elapsed: 2.322 s  <<< FAILURE!
java.lang.AssertionError: expected:<10> but was:<9>
	at org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testSelectQueriesWithFilters(ExplainPlanWithStatsEnabledIT.java:669)
	at org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testSelectQueriesWithStatsForParallelizationOff(ExplainPlanWithStatsEnabledIT.java:624)

[ERROR] testEstimatesForAggregateQueries(org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT)
 Time elapsed: 2.324 s  <<< ERROR!
java.lang.NullPointerException
	at org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testEstimatesForAggregateQueries(ExplainPlanWithStatsEnabledIT.java:560)

[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 155.149 s - in org.apache.phoenix.end2end.TenantSpecificTablesDDLIT
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 149.108 s - in org.apache.phoenix.end2end.TenantSpecificTablesDMLIT
[INFO] Tests run: 52, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 280.504 s - in org.apache.phoenix.end2end.ViewIT
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   ExplainPlanWithStatsEnabledIT.testBytesRowsForSelectOnTenantViews:426 expected:<2000>
but was:<null>
[ERROR]   ExplainPlanWithStatsEnabledIT.testSelectQueriesWithStatsForParallelizationOff:624->testSelectQueriesWithFilters:669
expected:<10> but was:<9>
[ERROR]   ExplainPlanWithStatsEnabledIT.testSelectQueriesWithStatsForParallelizationOn:629->testSelectQueriesWithFilters:669
expected:<10> but was:<9>
[ERROR] Errors: 
[ERROR]   ExplainPlanWithStatsEnabledIT.testBytesRowsForSelectWhenKeyOutOfRange:116 NullPointer
[ERROR]   ExplainPlanWithStatsEnabledIT.testEstimatesForAggregateQueries:560 NullPointer
[INFO] 
{code}


was (Author: jamestaylor):
Attached WIP patch with all the above implemented. Still need to fix ExplainPlanWithStatsEnabledIT.

> Stats - Incorrect estimate when stats are updated on a tenant specific view
> ---------------------------------------------------------------------------
>
>                 Key: PHOENIX-4333
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4333
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.12.0
>            Reporter: Mujtaba Chohan
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 4.14.0
>
>         Attachments: PHOENIX-4333_test.patch, PHOENIX-4333_v1.patch, PHOENIX-4333_v2.patch,
PHOENIX-4333_wip1.patch
>
>
> Consider two tenants A, B with tenant specific view on 2 separate regions/region servers.
> {noformat}
> Region 1 keys:
> A,1
> A,2
> B,1
> Region 2 keys:
> B,2
> B,3
> {noformat}
> When stats are updated on tenant A view. Querying stats on tenant B view yield partial
results (only contains stats for B,1) which are incorrect even though it shows updated timestamp
as current.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message