phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ohadshacham <...@git.apache.org>
Subject [GitHub] phoenix pull request #291: [PHOENIX-4278] Implement pure client side transac...
Date Thu, 08 Feb 2018 09:10:16 GMT
Github user ohadshacham commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/291#discussion_r166868712
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java ---
    @@ -1038,32 +1038,21 @@ public void setValue(PColumn column, byte[] byteValue) {
             @Override
             public void delete() {
                 newMutations();
    -            // we're using the Tephra column family delete marker here to prevent the
translation 
    -            // of deletes to puts by the Tephra's TransactionProcessor
    -            if (PTableImpl.this.isTransactional()) {
    -                Put put = new Put(key);
    -                if (families.isEmpty()) {
    -                    put.add(SchemaUtil.getEmptyColumnFamily(PTableImpl.this), TransactionFactory.getTransactionFactory().getTransactionContext().getFamilyDeleteMarker(),
ts,
    -                            HConstants.EMPTY_BYTE_ARRAY);
    -                } else {
    -                    for (PColumnFamily colFamily : families) {
    -                        put.add(colFamily.getName().getBytes(), TransactionFactory.getTransactionFactory().getTransactionContext().getFamilyDeleteMarker(),
ts,
    -                                HConstants.EMPTY_BYTE_ARRAY);
    -                    }
    -                }
    -                deleteRow = put;                
    --- End diff --
    
    No, since instead of writing directly the family deletion marker we perform a regular
delete operation using the transaction processor. The transaction processor writes this family
deletion marker and in here we just check for its existence. 


---

Mime
View raw message