From dev-return-48418-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed Jan 10 06:32:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 7C30B18062E for ; Wed, 10 Jan 2018 06:32:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6C179160C3F; Wed, 10 Jan 2018 05:32:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B2196160C17 for ; Wed, 10 Jan 2018 06:32:04 +0100 (CET) Received: (qmail 50587 invoked by uid 500); 10 Jan 2018 05:32:03 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 50576 invoked by uid 99); 10 Jan 2018 05:32:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 05:32:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4A21CC21F3 for ; Wed, 10 Jan 2018 05:32:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id GOP4r_GIKG2P for ; Wed, 10 Jan 2018 05:32:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 256215F343 for ; Wed, 10 Jan 2018 05:32:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5ADEEE023C for ; Wed, 10 Jan 2018 05:32:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 18208240DE for ; Wed, 10 Jan 2018 05:32:00 +0000 (UTC) Date: Wed, 10 Jan 2018 05:32:00 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4514) A incorrect key object is used in SequenceManager#validateSequences MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319715#comment-16319715 ] James Taylor commented on PHOENIX-4514: --------------------------------------- Thanks for the JIRA, [~chia7712]. Would you be up for providing a patch? > A incorrect key object is used in SequenceManager#validateSequences > ------------------------------------------------------------------- > > Key: PHOENIX-4514 > URL: https://issues.apache.org/jira/browse/PHOENIX-4514 > Project: Phoenix > Issue Type: Bug > Reporter: Chia-Ping Tsai > Priority: Minor > Fix For: 4.13.0, 5.0.0 > > > nextSequences.get( i ) -> nextSequences.get( i ).getSequenceKey() > {code:title=SequenceManager.java} > for (int i = 0; i < nextSequences.size(); i++) { > sequencePosition[i] = sequenceMap.get(nextSequences.get(i)).getIndex(); > } > {code} > It won't cause bug since the impl of SequenceAllocation#hashCode is equal with SequenceKey#hashCode. However, it still a potential bug so a fix is necessary I believe. > {code:title=SequenceAllocation.java} > @Override > public int hashCode() { > return sequenceKey.hashCode(); > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)