From dev-return-48743-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed Jan 24 00:40:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id D1950180621 for ; Wed, 24 Jan 2018 00:40:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C173F160C4D; Tue, 23 Jan 2018 23:40:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 13BF2160C3A for ; Wed, 24 Jan 2018 00:40:05 +0100 (CET) Received: (qmail 23739 invoked by uid 500); 23 Jan 2018 23:40:05 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 23728 invoked by uid 99); 23 Jan 2018 23:40:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jan 2018 23:40:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 857D3180879 for ; Tue, 23 Jan 2018 23:40:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.711 X-Spam-Level: X-Spam-Status: No, score=-108.711 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id W4v3x7hJutjU for ; Tue, 23 Jan 2018 23:40:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 60E285FD05 for ; Tue, 23 Jan 2018 23:40:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1C7CEE129D for ; Tue, 23 Jan 2018 23:40:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7644825C7C for ; Tue, 23 Jan 2018 23:40:00 +0000 (UTC) Date: Tue, 23 Jan 2018 23:40:00 +0000 (UTC) From: "Vincent Poon (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4130) Avoid server retries for mutable indexes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4130?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 336559#comment-16336559 ]=20 Vincent Poon commented on PHOENIX-4130: --------------------------------------- [~jamestaylor]=C2=A0Since we are now retrying from the client, is it necess= ary to set the REPLAY_WRITES (ignoreNewerMutations) attribute ? (i.e. since= the data table write succeeded, but the index write failed, and we're now = retrying the mutation from the client).=C2=A0 We went through=C2=A0some cha= nges with that flag so wasn't sure if that's still necessary for this scena= rio > Avoid server retries for mutable indexes > ---------------------------------------- > > Key: PHOENIX-4130 > URL: https://issues.apache.org/jira/browse/PHOENIX-4130 > Project: Phoenix > Issue Type: Improvement > Reporter: Lars Hofhansl > Assignee: Vincent Poon > Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4130.v1.master.patch, PHOENIX-4130.v2.master= .patch > > > Had some discussions with [~jamestaylor], [~samarthjain], and [~vincentpo= on], during which I suggested that we can possibly eliminate retry loops ha= ppening at the server that cause the handler threads to be stuck potentiall= y for quite a while (at least multiple seconds to ride over common scenario= s like splits). > Instead we can do the retries at the Phoenix client that. > So: > # The index updates are not retried on the server. (retries =3D 0) > # A failed index update would set the failed index timestamp but leave th= e index enabled. > # Now the handler thread is done, it throws an appropriate exception back= to the client. > # The Phoenix client can now retry. When those retries fail the index is = disabled (if the policy dictates that) and throw the exception back to its = caller. > So no more waiting is needed on the server, handler threads are freed imm= ediately. -- This message was sent by Atlassian JIRA (v7.6.3#76005)