phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4525) Integer overflow in GroupBy execution
Date Thu, 11 Jan 2018 22:15:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323070#comment-16323070
] 

James Taylor commented on PHOENIX-4525:
---------------------------------------

Nice find, [~sergey.soldatov]. +1 from me too.

> Integer overflow in GroupBy execution
> -------------------------------------
>
>                 Key: PHOENIX-4525
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4525
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.13.0
>            Reporter: Sergey Soldatov
>            Assignee: Sergey Soldatov
>         Attachments: PHOENIX-4525-2.patch, PHOENIX-4525.patch
>
>
> During the execution of group by we adjust memory for the internal cache to keep all
unique keys. We're increasing the number of keys by 1.5 factor and calculate how much space
we need for it using SizedUtil.sizeOfMap, which is using ints as parameters and returns long.
But since we are using all ints during the calculation, the integer overflow may happen and
the method would return a negative value. As the result the query would fail, reporting that
unable to allocate cache with negative size. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message