phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4514) A incorrect key object is used in SequenceManager#validateSequences
Date Wed, 10 Jan 2018 22:05:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321195#comment-16321195
] 

James Taylor commented on PHOENIX-4514:
---------------------------------------

+1 on the patch. Thanks for the contribution, [~chia7712]. I'll get this committed soon with
your other patch. Let me know if you need any guidance on potential future JIRAs to tackle.

> A incorrect key object is used in SequenceManager#validateSequences
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-4514
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4514
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Minor
>         Attachments: PHOENIX.4514.v0.patch
>
>
> nextSequences.get( i ) -> nextSequences.get( i ).getSequenceKey()
> {code:title=SequenceManager.java}
>         for (int i = 0; i < nextSequences.size(); i++) {
>             sequencePosition[i] = sequenceMap.get(nextSequences.get(i)).getIndex();
>         }
> {code}
> It won't cause bug since the impl of SequenceAllocation#hashCode is equal with SequenceKey#hashCode.
However, it still a potential bug so a fix is necessary I believe.
> {code:title=SequenceAllocation.java}
>     @Override
>     public int hashCode() {
>         return sequenceKey.hashCode();
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message