phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4514) A incorrect key object is used in SequenceManager#validateSequences
Date Wed, 10 Jan 2018 10:31:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320020#comment-16320020
] 

Hadoop QA commented on PHOENIX-4514:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12905409/PHOENIX.4514.v0.patch
  against master branch at commit 01642d5f948fb01f61e65d1bd58ff2661a8918db.
  ATTACHMENT ID: 12905409

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1705//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1705//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1705//console

This message is automatically generated.

> A incorrect key object is used in SequenceManager#validateSequences
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-4514
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4514
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Minor
>         Attachments: PHOENIX.4514.v0.patch
>
>
> nextSequences.get( i ) -> nextSequences.get( i ).getSequenceKey()
> {code:title=SequenceManager.java}
>         for (int i = 0; i < nextSequences.size(); i++) {
>             sequencePosition[i] = sequenceMap.get(nextSequences.get(i)).getIndex();
>         }
> {code}
> It won't cause bug since the impl of SequenceAllocation#hashCode is equal with SequenceKey#hashCode.
However, it still a potential bug so a fix is necessary I believe.
> {code:title=SequenceAllocation.java}
>     @Override
>     public int hashCode() {
>         return sequenceKey.hashCode();
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message