phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Created] (PHOENIX-4514) A incorrect key object is used in SequenceManager#validateSequences
Date Wed, 03 Jan 2018 10:22:00 GMT
Chia-Ping Tsai created PHOENIX-4514:
---------------------------------------

             Summary: A incorrect key object is used in SequenceManager#validateSequences
                 Key: PHOENIX-4514
                 URL: https://issues.apache.org/jira/browse/PHOENIX-4514
             Project: Phoenix
          Issue Type: Bug
            Reporter: Chia-Ping Tsai
            Priority: Minor
             Fix For: 4.13.0, 5.0.0


nextSequences.get( i ) -> nextSequences.get( i ).getSequenceKey()
{code:title=SequenceManager.java}
        for (int i = 0; i < nextSequences.size(); i++) {
            sequencePosition[i] = sequenceMap.get(nextSequences.get(i)).getIndex();
        }
{code}

It won't cause bug since the impl of SequenceAllocation#hashCode is equal with SequenceKey#hashCode.
However, it still a potential bug so a fix is necessary I believe.
{code:title=SequenceAllocation.java}
    @Override
    public int hashCode() {
        return sequenceKey.hashCode();
    }
{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message