phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #290: PHOENIX-4130 Avoid server retries for mutable ind...
Date Sat, 27 Jan 2018 05:29:23 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/290#discussion_r164264253
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexRebuilderIT.java
---
    @@ -1075,6 +1111,12 @@ public void testIndexFailureWithinRSDisablesIndex() throws Throwable
{
         public static class WriteFailingRegionObserver extends SimpleRegionObserver {
             @Override
             public void postBatchMutate(ObserverContext<RegionCoprocessorEnvironment>
c, MiniBatchOperationInProgress<Mutation> miniBatchOp) throws IOException {
    +            // we need to advance the clock, since the index retry logic (copied from
HBase) has a time component
    +            EnvironmentEdge delegate = EnvironmentEdgeManager.getDelegate();
    +            if (delegate instanceof MyClock) {
    +                MyClock myClock = (MyClock) delegate;
    +                myClock.time += 1000;
    +            }
    --- End diff --
    
    Do we still need this since you're using TableRef.getCurrentTime()? If yes, that's ok.


---

Mime
View raw message