Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9ECF3200D64 for ; Tue, 12 Dec 2017 02:17:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9D435160C23; Tue, 12 Dec 2017 01:17:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E24CC160C13 for ; Tue, 12 Dec 2017 02:17:03 +0100 (CET) Received: (qmail 33498 invoked by uid 500); 12 Dec 2017 01:17:03 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 33485 invoked by uid 99); 12 Dec 2017 01:17:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Dec 2017 01:17:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 99AADC222B for ; Tue, 12 Dec 2017 01:17:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -98.711 X-Spam-Level: X-Spam-Status: No, score=-98.711 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_NUMSUBJECT=0.5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id El9n-FDwA6Yw for ; Tue, 12 Dec 2017 01:17:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0BB3E626B5 for ; Tue, 12 Dec 2017 01:17:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 97A2AE129D for ; Tue, 12 Dec 2017 01:17:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2D400212FD for ; Tue, 12 Dec 2017 01:17:00 +0000 (UTC) Date: Tue, 12 Dec 2017 01:17:00 +0000 (UTC) From: "Sergey Soldatov (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (PHOENIX-4449) Incorrect behavior of sqlline after PHOENIX-3567 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 12 Dec 2017 01:17:04 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286913#comment-16286913 ] Sergey Soldatov edited comment on PHOENIX-4449 at 12/12/17 1:16 AM: -------------------------------------------------------------------- [~elserj] that's actually a regression. We should not provide any default value for the quorum in the python code. Otherwise, values from hbase-site.xml will be ignored all the time. What is the reason for execution an additional process to obtain the quorum address if it will be done automatically in phoenix. was (Author: sergey.soldatov): [~elserj] that's actually a regression. We should not provide any default value for the quorum in the python code. Otherwise, values from hbase-site.xml will be ignored all the time. > Incorrect behavior of sqlline after PHOENIX-3567 > ------------------------------------------------ > > Key: PHOENIX-4449 > URL: https://issues.apache.org/jira/browse/PHOENIX-4449 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.10.0, 4.13.0, 5.0.0 > Reporter: Sergey Soldatov > Assignee: Josh Elser > Priority: Critical > Fix For: 5.0.0, 4.14.0 > > Attachments: PHOENIX-4449.001.patch > > > In PHOENIX-3567 we have introduced a usage of argparse in sqlline as well as some default values for the parameters. That's not good because of: > 1. argparse is not a default package in old versions of python like 2.6.6 which is using in centos 6 distribution. > 2. We should not set a default value for zookeeper parent because if it's not specified in the command line, those values should be obtained from hbase client (hbase-site.xml or default values if it's not in the classpath). -- This message was sent by Atlassian JIRA (v6.4.14#64029)