phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs
Date Sun, 24 Dec 2017 16:34:02 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302889#comment-16302889
] 

Hadoop QA commented on PHOENIX-4489:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12903551/PHOENIX-4489.001.patch
  against master branch at commit 34693843abe4490b54fbd30512bf7d98d0f59c0d.
  ATTACHMENT ID: 12903551

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +                                    .getAttributesMap() + " [scanCache, cacheBlock, scanBatch]
: [" +
+                                    aScan.getCaching() + ", " + aScan.getCacheBlocks() +
", " + aScan
+                        psplits.add(new PhoenixInputSplit(Collections.singletonList(aScan),
regionSize, regionLocation));
+                                .get(0).getStartRow()) + " ~ " + Bytes.toStringBinary(scans.get(scans
+                                .get(0).getAttributesMap() + " [scanCache, cacheBlock, scanBatch]
: " +
+                                "[" + scans.get(0).getCaching() + ", " + scans.get(0).getCacheBlocks()

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1689//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1689//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1689//console

This message is automatically generated.

> HBase Connection leak in Phoenix MR Jobs
> ----------------------------------------
>
>                 Key: PHOENIX-4489
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4489
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Karan Mehta
>            Assignee: Karan Mehta
>         Attachments: PHOENIX-4489.001.patch
>
>
> Phoenix MR jobs uses a custom class {{PhoenixInputFormat}} to determine the splits and
the parallelism of the work. The class directly opens up a HBase connection, which is not
closed after the usage. Independently running MR jobs should not have any concern, however
jobs that run through Phoenix-Spark can cause leak issues if this is left unclosed (since
those jobs run as a part of same JVM). 
> Apart from this, the connection should be instantiated with {{HBaseFactoryProvider.getHConnectionFactory()}}
instead of the default one. It can be useful if a separate client is trying to run jobs and
wants to provide a custom implementation of {{HConnection}}. 
> [~jmahonin] Any ideas?
> [~jamestaylor] [~vincentpoon] Any concerns around this?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message