phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4468) Looking up a parent index table of a child view from a different client fails.
Date Mon, 18 Dec 2017 21:35:03 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295701#comment-16295701
] 

Hadoop QA commented on PHOENIX-4468:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12902700/PHOENIX-4468-4.x-HBase-0.98.patch
  against 4.x-HBase-0.98 branch at commit 5cb02da74c15b0ae7c0fb4c880d60a2d1b6d18aa.
  ATTACHMENT ID: 12902700

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +           if (c.contains(QueryConstants.CHILD_VIEW_INDEX_NAME_SEPARATOR) ) { throw new
RuntimeException("Table or schema name cannot contain hash"); }
+                    tenantId, PNameImpl.EMPTY_NAME, tableName, table.getType(), table.getIndexState(),
timeStamp,
+                String viewName = SchemaUtil.getTableNameFromFullName(name, QueryConstants.CHILD_VIEW_INDEX_NAME_SEPARATOR);
+                MetaDataMutationResult result = new MetaDataClient(pconn).updateCache(schemaName,
tableName);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ChildViewsUseParentViewIndexIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1676//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1676//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1676//console

This message is automatically generated.

> Looking up a parent index table of a child view from a different client fails. 
> -------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4468
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4468
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>             Fix For: 4.14.0, 4.13.2
>
>         Attachments: PHOENIX-4468-4.x-HBase-0.98.patch
>
>
> When you execute a query on a view, phoenix will use any indexes on the base table that
have all the required columns. We create a new PTable based on the parent table index and
tack on the view statement (to ensure we only see rows that we can access from the view).
This PTable is added to the client side connection metadata cache. This table is not available
on the server side (in SYSTEM.CATALOG).
> If you lookup the parent index table from a different client (that never ran a query
on the view), it will fail with a TableNotFoundException.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message