phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4456) queryserver script doesn't perform as expected.
Date Wed, 13 Dec 2017 10:11:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289019#comment-16289019
] 

Hadoop QA commented on PHOENIX-4456:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12901838/PHOENIX-4456.patch
  against master branch at commit 1a19d1ecbd38f2b7ee406df8efa05d29f685ef57.
  ATTACHMENT ID: 12901838

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1663//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1663//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1663//console

This message is automatically generated.

> queryserver script doesn't perform as expected.
> -----------------------------------------------
>
>                 Key: PHOENIX-4456
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4456
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.13.0, 5.0.0
>            Reporter: Sergey Soldatov
>            Assignee: Sergey Soldatov
>            Priority: Minor
>             Fix For: 5.0.0, 4.14.0
>
>         Attachments: PHOENIX-4456.patch
>
>
> Our queryserver.py is using a copy of daemon module. It has several flows:
> 1. it forks first, exit the parent process and after that create the pid file. So there
is a gap between the queryserver.py finished and the pid file created.
> 2. The check for existing pid is happening in forked process, so if we start queryserver
when there is already running one we wouldn't see the message that process is already running/started

> I've checked the more recent version from python 3.5 and it's still using the same logic.
> for (2) I think we may add an additinal check to PidFile.__init__, so it will happen
before we fork the daemon. For (1) there is an option to wait until pid file appears and only
after exit the parent process.
> FYI [~elserj]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message