phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Soldatov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4449) Incorrect behavior of sqlline after PHOENIX-3567
Date Tue, 12 Dec 2017 21:22:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288291#comment-16288291
] 

Sergey Soldatov commented on PHOENIX-4449:
------------------------------------------

Ah, got it. Didn't notice that argparse in its own directory and thought that it will be in
bin directory. But do we really need to log a message that there is no system argparse? That
would be quite annoying :)

bq. I expected not providing a URL on the command line would result in a malformed JDBC url
being used. 

No, if there is no zk quorum, than the call will be like 
{noformat}
java <....> PhoenixDriver -u jdbc:phoenix: 
{noformat}
and all corresponding fields will be filled from hbase configuration (and if there is no hbase-site.xml
it will use default localhost:2181:/hbase)


> Incorrect behavior of sqlline after PHOENIX-3567
> ------------------------------------------------
>
>                 Key: PHOENIX-4449
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4449
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.10.0, 4.13.0, 5.0.0
>            Reporter: Sergey Soldatov
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 5.0.0, 4.14.0
>
>         Attachments: PHOENIX-4449.001.patch
>
>
> In PHOENIX-3567 we have introduced a usage of argparse in sqlline as well as some default
values for the parameters. That's not good because of:
> 1. argparse is not a default package in old versions of python like 2.6.6 which is using
in centos 6 distribution. 
> 2. We should not set a default value for zookeeper parent because if it's not specified
in the command line, those values should be obtained from hbase client (hbase-site.xml or
default values if it's not in the classpath).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message