phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karan Mehta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4448) Remove complete dependency from Hadoop Metrics
Date Sat, 23 Dec 2017 01:08:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302151#comment-16302151
] 

Karan Mehta commented on PHOENIX-4448:
--------------------------------------

bq. I'm even more confused

Sorry about that. This is my understanding and correct me wherever required. Metrics2 is the
framework for transport of metrics (via JMX or custom sinks) as well as creating/defining
new metrics. We used this framework for transferring the HBase or Phoenix Apache HTrace traces
from source to sink (Sink is where those are written to a Phoenix table). PHOENIX-3752 removed
that source/sink logic and added a custom implementation. The current attached patch just
removes all the classes that are not being used anywhere and can be treated as a cleanup patch.

Now, could you clarify the scope of {{Hadoop Metrics2}}? Is using {{MetricHistogram}}, an
interface from this library a direct dependency? All the other classes that I have deleted
in this patch used Metrics. The class {{MetricsIndexerSourceImpl}} currently creates histograms
on index metrics. From what I understand, they are not dependent on HBase metrics. Are you
suggesting that we should change them to use the HBase metrics api instead? FYI. At this point,
I am not sure, how they are handled or exposed.

[~aertoria], do you have any insight to this?

> Remove complete dependency from Hadoop Metrics
> ----------------------------------------------
>
>                 Key: PHOENIX-4448
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4448
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Karan Mehta
>            Assignee: Karan Mehta
>         Attachments: PHOENIX-4448.001.patch
>
>
> PHOENIX-3757 removed the usage of Hadoop Metrics API and the sink. However there are
still some classes that are lying in place and probably not being used elsewhere. This JIRA
is to track the cleanup of those classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message