phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vincent Poon (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4442) Rename system catalog INDEX_STATE to STATE
Date Thu, 07 Dec 2017 19:18:00 GMT


Vincent Poon commented on PHOENIX-4442:

I don't know if this is a good idea - it might be confusing as indexes have additional states
such as "rebuild", "building", etc.  The refactoring in the codebase would be a mess if we
were to rename PIndexState, and would make the code less readable.  Furthermore an index name
doesn't always map directly to a table name, in some cases it's just a logical name that maps
to a physical table.  I don't see much gain from reusing this column, versus the cost of making
the code less clear.

> Rename system catalog INDEX_STATE to STATE
> ------------------------------------------
>                 Key: PHOENIX-4442
>                 URL:
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Ethan Wang
> Rename system catalog INDEX_STATE to STATE so that this column can be used for table
as well

This message was sent by Atlassian JIRA

View raw message