phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas D'Silva (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PHOENIX-4432) PHOENIX-672 documentation
Date Fri, 15 Dec 2017 20:23:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293068#comment-16293068
] 

Thomas D'Silva edited comment on PHOENIX-4432 at 12/15/17 8:22 PM:
-------------------------------------------------------------------

[~karanmehta93] Looks good with a few changes. 

shouldn't 
{code}
[ON [SCHEMA schemaName] tableName] 
{code}
be 
{code}
[ON [SCHEMA? schemaName] OR  [TABLE? tableName]]
{code}

Change first sentence to table, schema or global level (to match hbase doc about scopes).
Move second sentence to the refer section (Permissions are managed by HBase in the hbase:acl
table, hence access controls need to be enabled) 
Also add a sentence along the lines of "In order to use sequences users also need W access
to the SYSTEM.SEQUENCE table". 

Make the same changes for the revoke section. 

The revoke statement ignores the  permission string that is passed in and revokes all permissions
right? Can you make that clear and also change to revoke syntax to include the permissions
string ?
Change "revoking 'RX' permissions ... " to just match the two sentences in the GRANT section
about SYTEM tables.


was (Author: tdsilva):
[~karanmehta93] Looks good with a few changes. 

shouldn't 
{code}
[ON [SCHEMA schemaName] tableName] 
{code}
be 
{code}
[ON [SCHEMA? schemaName] OR  [TABLE? tableName]]
{code}

Change first sentence to table, schema or global level (to match hbase doc about scopes).
Move second sentence to the refer section (Permissions are managed by HBase in the hbase:acl
table, hence access controls need to be enabled) 
Also add a sentence along the lines of "In order to use sequences users also need W access
to the SYSTEM.SEQUENCE table". 

Make the same changes for the revoke section. 

The revoke statement ignores the  permission string that is passed in and revokes all permissions
right? Can you make that clear and also change to revoke syntax to include the permissions
string ?
Change "evoking 'RX' permissions ... " to just match the two sentences in the GRANT section
about SYTEM tables.

> PHOENIX-672 documentation
> -------------------------
>
>                 Key: PHOENIX-4432
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4432
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Karan Mehta
>            Assignee: Karan Mehta
>              Labels: documentation
>         Attachments: PHOENIX-4432.001.patch
>
>
> Now that PHOENIX-672 is in and users can GRANT/REVOKE permissions on users, tables and
namespaces, we should document this feature and add it to our grammar syntax on the website,
so that users can start using it. 
> This JIRA is for tracking that effort.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message