phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4424) Allow users to create "DEFAULT" and "HBASE" Schema (Uppercase Schema Names)
Date Mon, 04 Dec 2017 21:48:00 GMT


Hadoop QA commented on PHOENIX-4424:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit 88038a2dacb7aa1a90015163d4d75d04793e4e11.
  ATTACHMENT ID: 12900529

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 3 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +            verifyAllowed(grantPermissions("C", regularUser1, "\"" + SchemaUtil.SCHEMA_FOR_DEFAULT_NAMESPACE
+ "\"", true), superUser1);
+            verifyAllowed(grantPermissions("C", regularUser1, "\"" + SchemaUtil.SCHEMA_FOR_DEFAULT_NAMESPACE
+ "\"", true), superUser1);
+        // ddl2 should create uppercase schemaName since Phoenix upper-cases identifiers
without quotes
+        // Create schema DEFAULT and HBASE (Should allow since they are upper-cased) and
verify that it exists
+             HBaseAdmin admin = conn.unwrap(PhoenixConnection.class).getQueryServices().getAdmin();)
+            assertNotNull(admin.getNamespaceDescriptor(SchemaUtil.SCHEMA_FOR_DEFAULT_NAMESPACE.toUpperCase()));
+                schemaName)) { throw new SQLExceptionInfo.Builder(SQLExceptionCode.SCHEMA_NOT_ALLOWED)
+                if(!changePermsStatement.getSchemaName().equals(SchemaUtil.SCHEMA_FOR_DEFAULT_NAMESPACE))

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Release audit warnings:
Console output:

This message is automatically generated.

> Allow users to create "DEFAULT" and "HBASE" Schema (Uppercase Schema Names)
> ---------------------------------------------------------------------------
>                 Key: PHOENIX-4424
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Karan Mehta
>            Assignee: Karan Mehta
>         Attachments: PHOENIX-4424.001.patch, PHOENIX-4424.002.patch
> We currently block users to create "DEFAULT" and "HBASE" schema, however it should be
actually "default" and "hbase" since hbase namespace is case sensitive. Hence we should update
it and allow is users want to create schema's with those names.
> If user wants to access the schema names with capital letters, they can pass it in directly
(Phoenix will automatically upper-case it) or pass it in uppercase letters with double-quotes.
> FYI.
> []

This message was sent by Atlassian JIRA

View raw message