phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4382) Upsert of some big values not correct for immutable tables
Date Tue, 19 Dec 2017 19:35:00 GMT


Hadoop QA commented on PHOENIX-4382:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit 9d8be0e9214ba3680a81c399c5da316c1b91c99b.
  ATTACHMENT ID: 12902900

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +                table.getImmutableStorageScheme() == ImmutableStorageScheme.SINGLE_CELL_ARRAY_WITH_OFFSETS
+    private <T extends Number> void testValues(boolean immutable, PDataType<?>
dataType, List<T> testData) throws Exception {
+    public SingleCellColumnExpression(PColumn column, String displayName, QualifierEncodingScheme
encodingScheme, ImmutableStorageScheme immutableStorageScheme) {
+                    }, dataColRef.getFamily(), dataColRef.getQualifier(), encodingScheme,
+        KeyValueColumnExpression kvExp = scheme != PTable.ImmutableStorageScheme.ONE_CELL_PER_COLUMN
? new SingleCellColumnExpression(scheme)
+                return new PArrayDataTypeEncoder(byteStream, oStream, numElements, type,
SortOrder.ASC, false, getSerializationVersion());
+    // array serialization format where bytes are immutable (does not support prepend/append
or sorting)
+    if (serializationVersion == IMMUTABLE_SERIALIZATION_VERSION || serializationVersion ==
+                    if (isNullValue(arrayIndex, bytes, initPos, serializationVersion, useShort,
indexOffset, currOffset, elementLength)) {
+                    int separatorBytes =  serializationVersion == PArrayDataType.SORTABLE_SERIALIZATION_VERSION
? 3 : 0;

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Release audit warnings:
Console output:

This message is automatically generated.

> Upsert of some big values not correct for immutable tables
> ----------------------------------------------------------
>                 Key: PHOENIX-4382
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.0
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>         Attachments: PHOENIX-4382.v1.master.patch, PHOENIX-4382.v2.master.patch,
> For immutable tables, upsert of some values like Short.MAX_VALUE results in a null value
in query resultsets.  Mutable tables are not affected.  I tried with BigInt and got the same
> For Short, the breaking point seems to be 32512.  Numbers smaller than that are fine
(until you get closer to Short.MIN_VALUE...)
> See attached test - testShort() , testBigInt()

This message was sent by Atlassian JIRA

View raw message