phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pedro Boado <pedro.bo...@gmail.com>
Subject Re: Query - right way of getting a PR reviewed?
Date Sat, 16 Dec 2017 12:11:22 GMT
How can I tell QA Jenkins to analyse/apply the patch against the right
branch instead of master?

On 16 December 2017 at 10:57, Pedro Boado <pedro.boado@gmail.com> wrote:

> Hi all,
>
> I've filed https://issues.apache.org/jira/browse/PHOENIX-4461 for
> requesting the test run. Can anyone please look into it?
>
> Cheers.
>
> On 13 December 2017 at 08:49, Pedro Boado <pedro.boado@gmail.com> wrote:
>
>> Hi James,
>>
>> Yes I've run all long IT and they are all passing, I can attach build
>> logs later today if needed.
>>
>> Cheers.
>>
>> On 13 Dec 2017 12:18 am, "James Taylor" <jamestaylor@apache.org> wrote:
>>
>>> Hi Pedro,
>>> Pinging the dev list is fine to prod us into committing something. I'd
>>> recommend filing a JIRA and submitting a patch on the JIRA to get a test
>>> run. If you've run the tests locally already and they all pass, then it
>>> should be fine to commit it as well.
>>> Thanks,
>>> James
>>>
>>> On Tue, Dec 12, 2017 at 3:59 PM, Pedro Boado <pedro.boado@gmail.com>
>>> wrote:
>>>
>>> > Hi all,
>>> >
>>> > I've just cherry picked all current changes from master onto
>>> 4.x-HBase-1.2
>>> > and sent a PR ( https://github.com/apache/phoenix/pull/286 ) . What
>>> is the
>>> > right way of requesting this PR to be reviewed as part of the
>>> 4.x-HBase-1.2
>>> > maintenance?  In here via email?
>>> >
>>> > --
>>> > Un saludo.
>>> > Pedro Boado.
>>> >
>>>
>>
>
>
> --
> Un saludo.
> Pedro Boado.
>



-- 
Un saludo.
Pedro Boado.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message