phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karanmehta93 <>
Subject [GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...
Date Mon, 04 Dec 2017 18:43:37 GMT
Github user karanmehta93 commented on a diff in the pull request:
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/ ---
    @@ -4125,7 +4125,7 @@ public MutationState createSchema(CreateSchemaStatement create)
throws SQLExcept
         private void validateSchema(String schemaName) throws SQLException {
             if (SchemaUtil.NOT_ALLOWED_SCHEMA_LIST.contains(
    -                schemaName.toUpperCase())) { throw new SQLExceptionInfo.Builder(SQLExceptionCode.SCHEMA_NOT_ALLOWED)
    --- End diff --
    @ankitsinghal Thanks for your comments. Please checkout v2 of the patch. I have fixed
the bug and I updated the test to verify those scenarios. I also made sure that we don't normalize
schema names multiple times, else schema names will always be in capital letters.
    FYI. @twdsilva


View raw message