phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karanmehta93 <...@git.apache.org>
Subject [GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...
Date Fri, 01 Dec 2017 06:35:04 GMT
Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/284#discussion_r154276336
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -4125,7 +4125,7 @@ public MutationState createSchema(CreateSchemaStatement create)
throws SQLExcept
     
         private void validateSchema(String schemaName) throws SQLException {
             if (SchemaUtil.NOT_ALLOWED_SCHEMA_LIST.contains(
    -                schemaName.toUpperCase())) { throw new SQLExceptionInfo.Builder(SQLExceptionCode.SCHEMA_NOT_ALLOWED)
    --- End diff --
    
    Also checkout the test I updated in `CreateSchemaIT` class.


---

Mime
View raw message