phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karanmehta93 <...@git.apache.org>
Subject [GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...
Date Fri, 01 Dec 2017 06:29:00 GMT
Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/284#discussion_r154275774
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/CreateSchemaStatement.java
---
    @@ -24,7 +24,7 @@
     	private final boolean ifNotExists;
     	
     	public CreateSchemaStatement(String schemaName,boolean ifNotExists) {
    -		this.schemaName = null == schemaName ? SchemaUtil.SCHEMA_FOR_DEFAULT_NAMESPACE : schemaName;
    +		this.schemaName = SchemaUtil.normalizeIdentifier(schemaName);
    --- End diff --
    
    @JamesRTaylor from JIRA comment
    > Identifiers are case sensitive when they are double quoted in Phoenix (and SQL in
general). Otherwise they are uppercased. We shouldn’t/can’t change that.
    
    This code change will now make it adhere to SQL standards. The `SchemaUtil.normalizeIdentifier`
will help handle the case sensitivity. Otherwise with the current code, if a schema name is
passed with double quotes, the full name will be taken as it is for creating the schema, which
is incorrect. 
    
    Also look for comments in `MetaDataClient` as well.


---

Mime
View raw message