Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Tue, 14 Nov 2017 16:56:00 +0000 (UTC)
From: "Josh Elser (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13118202.1510654783000.234983.1510678560186@Atlassian.JIRA>
In-Reply-To: <JIRA.13118202.1510654783000@Atlassian.JIRA>
References: <JIRA.13118202.1510654783000@Atlassian.JIRA> <JIRA.13118202.1510654783402@jira-lw-us.apache.org>
Subject: [jira] [Commented] (PHOENIX-4376) Fix all compilation error for
 package org.apache.phoenix.schema.stats and org.apache.phoenix.coprocessor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 14 Nov 2017 16:56:04 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251720#comment-16251720 ] 

Josh Elser commented on PHOENIX-4376:
-------------------------------------

{code}
+      if (scan.isRaw() || ScanInfoUtil.isKeepDeletedCells(((HStore)store).getScanInfo()) || scan.getTimeRange().getMax() == HConstants.LATEST_TIMESTAMP || TransactionUtil.isTransactionalTimestamp(scan.getTimeRange().getMax())) {
{code}

We should get rid of the {{((HStore) store).getScanInfo()}}. Can you switch {{ScanInfoUtil.isKeepDeleteCells}} to take a {{Store}} and have the method use {{store.getColumnFamilyDescriptor().getKeepDeletedCells()}} instead?

+1 otherwise.

> Fix all compilation error for package org.apache.phoenix.schema.stats and org.apache.phoenix.coprocessor
> --------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4376
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4376
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>              Labels: HBase-2.0
>             Fix For: 5.0.0
>
>         Attachments: PHOENIX-4376.patch
>
>
> -- It includes updating the coprocessor hook with right definition.
> -- Changing HRegionInfo to RegionInfo.
> -- Cell related changes.
> Like 
> {code}
> -        byte[] viewConstant = viewConstantKv == null ? null : viewConstantKv.getValue();
> +        byte[] viewConstant = viewConstantKv == null ? null : CellUtil.cloneValue(viewConstantKv);
> -                    Cell viewStatementCell = new KeyValue(cell.getRow(), cell.getFamily(), VIEW_STATEMENT_BYTES,
> +                    Cell viewStatementCell = new KeyValue(CellUtil.cloneRow(cell), CellUtil.cloneFamily(cell), VIEW_STATEMENT_BYTES,
> {code}
> -- Update scan 
> {code}
> -            scan.setStartRow(HConstants.EMPTY_START_ROW);
> -            scan.setStopRow(HConstants.EMPTY_END_ROW);
> +            scan.withStartRow(HConstants.EMPTY_START_ROW);
> +            scan.withStopRow(HConstants.EMPTY_END_ROW);
> {code}
> -- preSplit hook needs to be removed and fixed in PHOENIX-4352.
> -- Requires a separate fix of PHOENIX-4277 and PHOENIX-3081 for HBase 2.0


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)