Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 48DC8200D45 for ; Wed, 8 Nov 2017 10:10:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 47634160BDA; Wed, 8 Nov 2017 09:10:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 916EF160BE0 for ; Wed, 8 Nov 2017 10:10:09 +0100 (CET) Received: (qmail 34054 invoked by uid 500); 8 Nov 2017 09:10:04 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 33817 invoked by uid 99); 8 Nov 2017 09:10:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Nov 2017 09:10:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 15D4918077C for ; Wed, 8 Nov 2017 09:10:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 7HbecKmiWOv9 for ; Wed, 8 Nov 2017 09:10:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CEA165F477 for ; Wed, 8 Nov 2017 09:10:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 67D9CE05B7 for ; Wed, 8 Nov 2017 09:10:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 27CBE2419F for ; Wed, 8 Nov 2017 09:10:00 +0000 (UTC) Date: Wed, 8 Nov 2017 09:10:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4358) Case Sensitive String match on SqlType in PDataType MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 08 Nov 2017 09:10:10 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243561#comment-16243561 ] Hadoop QA commented on PHOENIX-4358: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12896574/caseFix.patch against master branch at commit 4a1f0df6143ba705a48b5051aee52dab158afe8d. ATTACHMENT ID: 12896574 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinNoIndexIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1621//testReport/ Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1621//console This message is automatically generated. > Case Sensitive String match on SqlType in PDataType > --------------------------------------------------- > > Key: PHOENIX-4358 > URL: https://issues.apache.org/jira/browse/PHOENIX-4358 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.11.0 > Environment: OSX and Linux > Reporter: Dave Angulo > Priority: Minor > Attachments: caseFix.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > fromSqlTypeName() method uses a case sensitive match on input SqlType. This causes an issue in Spark JDBCUtils.makeSetter() which lowerCases input. The result is the error _Unsupported sql type: varchar_. -- This message was sent by Atlassian JIRA (v6.4.14#64029)