Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A1946200D4B for ; Mon, 27 Nov 2017 19:51:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9E7FE160C14; Mon, 27 Nov 2017 18:51:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E62E1160BFA for ; Mon, 27 Nov 2017 19:51:03 +0100 (CET) Received: (qmail 48772 invoked by uid 500); 27 Nov 2017 18:51:03 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 48761 invoked by uid 99); 27 Nov 2017 18:51:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Nov 2017 18:51:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2802BC1565 for ; Mon, 27 Nov 2017 18:51:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.011 X-Spam-Level: X-Spam-Status: No, score=-99.011 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KB_WAM_FROM_NAME_SINGLEWORD=0.2, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 0iSyh1JZrpUi for ; Mon, 27 Nov 2017 18:51:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 48C685F177 for ; Mon, 27 Nov 2017 18:51:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D2B25E0F1E for ; Mon, 27 Nov 2017 18:51:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 514D6241BC for ; Mon, 27 Nov 2017 18:51:00 +0000 (UTC) Date: Mon, 27 Nov 2017 18:51:00 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4322) DESC primary key column with variable length does not work in SkipScanFilter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 27 Nov 2017 18:51:04 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267240#comment-16267240 ] James Taylor commented on PHOENIX-4322: --------------------------------------- Ping [~maryannxue]. Are you planning on pursuing this one? I think you need to look at the code that generates the row key for RVCs and prevent any trailing separators from being added. > DESC primary key column with variable length does not work in SkipScanFilter > ---------------------------------------------------------------------------- > > Key: PHOENIX-4322 > URL: https://issues.apache.org/jira/browse/PHOENIX-4322 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.11.0 > Reporter: Maryann Xue > Assignee: Maryann Xue > Priority: Minor > Fix For: 4.14.0 > > > Example: > {code} > @Test > public void inDescCompositePK3() throws Exception { > String table = generateUniqueName(); > String ddl = "CREATE table " + table + " (oid VARCHAR NOT NULL, code VARCHAR NOT NULL constraint pk primary key (oid DESC, code DESC))"; > Object[][] insertedRows = new Object[][]{{"o1", "1"}, {"o2", "2"}, {"o3", "3"}}; > runQueryTest(ddl, upsert("oid", "code"), insertedRows, new Object[][]{{"o2", "2"}, {"o1", "1"}}, new WhereCondition("(oid, code)", "IN", "(('o2', '2'), ('o1', '1'))"), > table); > } > {code} > Here the last column in primary key is in DESC order and has variable length, and WHERE clause involves an "IN" operator with RowValueConstructor specifying all PK columns. We get no results. > This ends up being the root cause for not being able to use child/parent join optimization on DESC pk columns as described in PHOENIX-3050. -- This message was sent by Atlassian JIRA (v6.4.14#64029)