Return-Path: <dev-return-47011-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 8D1E6200D3E
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 16 Nov 2017 22:25:17 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 8BACA160BEA; Thu, 16 Nov 2017 21:25:17 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id C7C081609EF
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 16 Nov 2017 22:25:16 +0100 (CET)
Received: (qmail 487 invoked by uid 500); 16 Nov 2017 21:25:15 -0000
Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@phoenix.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@phoenix.apache.org>
List-Post: <mailto:dev@phoenix.apache.org>
List-Id: <dev.phoenix.apache.org>
Reply-To: dev@phoenix.apache.org
Delivered-To: mailing list dev@phoenix.apache.org
Received: (qmail 476 invoked by uid 99); 16 Nov 2017 21:25:15 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Nov 2017 21:25:15 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 9D3E8DFCF7; Thu, 16 Nov 2017 21:25:14 +0000 (UTC)
From: aertoria <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-282-phoenix@git.apache.org>
In-Reply-To: <git-pr-282-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request #282: PHOENIX-4361: Remove redundant argument in separa...
Content-Type: text/plain
Message-Id: <20171116212514.9D3E8DFCF7@git1-us-west.apache.org>
Date: Thu, 16 Nov 2017 21:25:14 +0000 (UTC)
archived-at: Thu, 16 Nov 2017 21:25:17 -0000

Github user aertoria commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/282#discussion_r151541162
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ---
    @@ -1940,7 +1940,8 @@ private void setTransactional(HTableDescriptor tableDescriptor, PTableType table
             this.addCoprocessors(tableDescriptor.getName(), tableDescriptor, tableType, tableProps);
         }
     
    -    private Pair<HTableDescriptor,HTableDescriptor> separateAndValidateProperties(PTable table, Map<String, List<Pair<String, Object>>> properties, Set<String> colFamiliesForPColumnsToBeAdded, List<Pair<byte[], Map<String, Object>>> families, Map<String, Object> tableProps) throws SQLException {
    +    private Pair<HTableDescriptor,HTableDescriptor> separateAndValidateProperties(PTable table, Map<String, List<Pair<String, Object>>> properties,
    --- End diff --
    
    nit: Please undo this change


---